-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split rest endpoints and improve modularisation #817
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
melowe
commented
Jul 13, 2019
•
edited
Loading
edited
- Move JAX-RS endpoints into distinct modules and don't use spring to instantiate JAX-RS objects.
- Move JPA focused code into distinct module to prevent circular dependency when trying to use DAOs in modules external to core/transaction
- Remove GRPC modules and related code
- Start phasing out loading spring managed objects via ServiceLocator, providing a ServiceFactory to limit access to ServiceLoader.
into application objects.
Remove grpc dependencies Ennforce version for jetty utils.
ServiceLocator.getServices() to ServiceFactory .
Conflicts: jaxrs-service/src/main/java/com/quorum/tessera/api/exception/KeyNotFoundExceptionMapper.java jaxrs-service/src/test/java/com/quorum/tessera/api/exception/KeyNotFoundExceptionMapperTest.java
2.Add mock p2p client factory for tests 3. Use serviceFactory to inject objects into payload publisher improving encapulation and meaning it can also be created via service loader. 4. Add factory function to PayloadPublisher meaing altrenatives can be provided via class loader and META-INF/services
2.Add mock p2p client factory for tests 3. Use serviceFactory to inject objects into payload publisher improving encapulation and meaning it can also be created via service loader. 4. Add factory function to PayloadPublisher meaing altrenatives can be provided via class loader and META-INF/services
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
=========================================
Coverage ? 99.48%
Complexity ? 2032
=========================================
Files ? 305
Lines ? 6000
Branches ? 300
=========================================
Hits ? 5969
Misses ? 5
Partials ? 26
Continue to review full report at Codecov.
|
ResendManager and other objects to move into correct module.
|
melowe
changed the title
Split rest endpoints
Split rest endpoints and improve modularisation
Jul 17, 2019
melowe
requested review from
chris-j-h,
namtruong,
nicolae-leonte-go,
prd-fox and
SatpalSandhu61
as code owners
July 17, 2019 13:06
Conflicts: jaxrs-service/src/test/java/com/quorum/tessera/jaxrs/JaxrsITConfig.java tests/acceptance-test/pom.xml
prd-fox
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.